Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workinghours.md #9416

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Update workinghours.md #9416

merged 3 commits into from
Sep 19, 2024

Conversation

DenWin
Copy link
Contributor

@DenWin DenWin commented Sep 13, 2024

Information about the modern UI for working hours and that it is not yet supported.

Instructions: Add any supporting information, such as a description of the PR changes, here.


Note

The following guidance is for Microsoft employees only. Community contributors can ignore this message; our content team will manage the status.

After you've created your PR, expand this section for tips and additional instructions.
  • do not merge is the default PR status and is automatically added to all open PRs that don't have the ready to merge label.
  • Add the ready for content review label to start a review. Your PR won't be reviewed until you add this label.
  • If your content reviewer requests changes, review the feedback and address accordingly as soon as possible to keep your pull request moving forward. After you address the feedback, remove the changes requested label, add the review feedback addressed label, and select the Re-request review icon next to the content reviewer's alias. If you can't add labels, add a comment with #feedback-addressed to the pull request.
  • After the content review is complete, your reviewer will add the content review complete label. When the updates in this PR are ready for external customers to use, replace the do not merge label with ready to merge and the PR will be merged within 24 working hours.
  • Pull requests that are inactive for more than 6 weeks will be automatically closed. Before that, you receive reminders at 2 weeks, 4 weeks, and 6 weeks. If you still need the PR, you can reopen or recreate the request.

For more information, see the Content review process summary.

Information about the modern UI for working hours and that it is not yet supported.
Copy link

Learn Build status updates of commit f80e107:

✅ Validation status: passed

File Status Preview URL Details
api-reference/v1.0/resources/workinghours.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@@ -53,6 +53,11 @@ The following JSON representation shows the resource type.
}
```

## Modern Working Hours
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally don't surface feedback portal requests in our documentation. Instead of adding this section here, perhaps we can have a note in the introduction to the topic, like this:

Note: The working hours experience in new Outlook and Outlook on the web isn't currently supported.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjusted accordingly.

adjusted according to feedback
Copy link

Learn Build status updates of commit 24ee270:

✅ Validation status: passed

File Status Preview URL Details
api-reference/v1.0/resources/workinghours.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@Lauragra Lauragra added content review complete Apply when the content review is complete on a PR. ready to merge Use this label to indicate to the repository admins that your PR is ready to merge into master. and removed changes requested content review in progress labels Sep 19, 2024
@Lauragra Lauragra merged commit ac51bb0 into microsoftgraph:main Sep 19, 2024
6 of 7 checks passed
Copy link

Learn Build status updates of commit 3e9c738:

✅ Validation status: passed

File Status Preview URL Details
api-reference/beta/resources/workinghours.md ✅Succeeded
api-reference/v1.0/resources/workinghours.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content review complete Apply when the content review is complete on a PR. ready to merge Use this label to indicate to the repository admins that your PR is ready to merge into master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants